From: Yongmin Yoo 유용민 Date: Sat, 25 Jul 2026 12:32:37 +0000 (+0900) Subject: Update ggml/src/gguf.cpp : Defined virtual keyword for destructor of gguf_writer_base... X-Git-Tag: upstream/0.0.10438~314 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=fb92d8f1873c96ec63f9c59721d58a55bf46d441;p=pkg%2Fggml%2Fsources%2Fllama.cpp Update ggml/src/gguf.cpp : Defined virtual keyword for destructor of gguf_writer_base (#25867) Without a virtual destructor, deleting a derived object through a base-class pointer only invokes the base destructor, skipping the derived one. --- diff --git a/ggml/src/gguf.cpp b/ggml/src/gguf.cpp index 7920b8100..9f9e4fe5d 100644 --- a/ggml/src/gguf.cpp +++ b/ggml/src/gguf.cpp @@ -1424,7 +1424,7 @@ void gguf_set_tensor_data(struct gguf_context * ctx, const char * name, const vo struct gguf_writer_base { size_t written_bytes {0u}; - ~gguf_writer_base(void) = default; + virtual ~gguf_writer_base(void) = default; // we bet on devirtualization virtual void write(int8_t val) = 0;