From: DAN™ <redacted>
Date: Fri, 22 Mar 2024 01:32:42 +0000 (-0400)
Subject: Fix params underscore convert to dash. (#6203)
X-Git-Tag: upstream/0.0.4488~1996
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=fa046eafbc70bf97dcf39843af0323f19a8c9ac3;p=pkg%2Fggml%2Fsources%2Fllama.cpp

Fix params underscore convert to dash. (#6203)

* Fix params underscore convert to dash.

* Update common/common.cpp

---------

Co-authored-by: slaren <redacted>
---

diff --git a/common/common.cpp b/common/common.cpp
index 192182d0..11bf554d 100644
--- a/common/common.cpp
+++ b/common/common.cpp
@@ -154,8 +154,7 @@ bool gpt_params_parse(int argc, char ** argv, gpt_params & params) {
     return result;
 }
 
-static bool gpt_params_find_arg(int argc, char ** argv, gpt_params & params, int & i, bool & invalid_param) {
-    std::string arg = argv[i];
+static bool gpt_params_find_arg(int argc, char ** argv, const std::string & arg, gpt_params & params, int & i, bool & invalid_param) {
     llama_sampling_params& sparams = params.sparams;
 
     if (arg == "-s" || arg == "--seed") {
@@ -1201,7 +1200,7 @@ bool gpt_params_parse_ex(int argc, char ** argv, gpt_params & params) {
             std::replace(arg.begin(), arg.end(), '_', '-');
         }
 
-        if (!gpt_params_find_arg(argc, argv, params, i, invalid_param)) {
+        if (!gpt_params_find_arg(argc, argv, arg, params, i, invalid_param)) {
             throw std::invalid_argument("error: unknown argument: " + arg);
         }
     }