From: Sigbjørn Skjæret <redacted>
Date: Mon, 7 Jul 2025 21:35:35 +0000 (+0200)
Subject: llama : fix incorrect minicpm3 v_states shape (#14571)
X-Git-Tag: upstream/0.0.5882~44
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=e1a7059053a9b8958f2d57a21fc46dbc7fb24f8e;p=pkg%2Fggml%2Fsources%2Fllama.cpp

llama : fix incorrect minicpm3 v_states shape (#14571)
---

diff --git a/src/llama-model.cpp b/src/llama-model.cpp
index d0cbe046..29ded0af 100644
--- a/src/llama-model.cpp
+++ b/src/llama-model.cpp
@@ -8699,11 +8699,6 @@ struct llm_build_minicpm3 : public llm_graph_context {
                 v_states = ggml_cont(ctx0, v_states);
                 cb(v_states, "v_states", il);
 
-                v_states = ggml_view_2d(ctx0, v_states, hparams.n_embd_head_v * n_head, n_tokens,
-                        ggml_row_size(kv->type, hparams.n_embd_head_v * n_head),
-                        0);
-                cb(v_states, "v_states", il);
-
                 q_pe = ggml_rope_ext(
                         ctx0, q_pe, inp_pos, rope_factors,
                         n_rot, rope_type, n_ctx_orig, freq_base, freq_scale,