From: Daniel Bevenius Date: Fri, 12 Dec 2025 12:25:16 +0000 (+0100) Subject: model-conversion : remove max diff check in compare-logits [no ci] (#17954) X-Git-Tag: upstream/0.0.7446~81 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=dada4c846df5e2bea1800e70b56ceacac7cfb54b;p=pkg%2Fggml%2Fsources%2Fllama.cpp model-conversion : remove max diff check in compare-logits [no ci] (#17954) This commit removes the maximum difference check from the compare-logits.py which would stop early if the difference between the logits exceeded a threshold. The motivation for removing this is that it can be useful to be able to get the complete log for debugging/reporting purposes. --- diff --git a/examples/model-conversion/scripts/causal/compare-logits.py b/examples/model-conversion/scripts/causal/compare-logits.py index afa0d5b2..27447890 100755 --- a/examples/model-conversion/scripts/causal/compare-logits.py +++ b/examples/model-conversion/scripts/causal/compare-logits.py @@ -32,10 +32,6 @@ def quick_logits_check(pytorch_file, llamacpp_file): print(f"Top 10 llama.cpp logits: {llamacpp_logits[llamacpp_top10]}") print(f"Max absolute difference: {max_diff:.4f}") - if max_diff > 1.0: - print(f"❌ NOK: Large differences detected - max diff: {max_diff:.4f}") - return False - return True def main():