From: Daniel Bevenius Date: Wed, 9 Oct 2024 14:40:35 +0000 (+0200) Subject: ggml-alloc : remove buffer_id from leaf_alloc (ggml/987) X-Git-Tag: upstream/0.0.4488~563 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=cd60b88bf7ad7785fb6ac9864e360cf10e42faad;p=pkg%2Fggml%2Fsources%2Fllama.cpp ggml-alloc : remove buffer_id from leaf_alloc (ggml/987) This commit removes the buffer_id field from the leaf_alloc struct. The motivation for is that this field is only written to and never read/used as far as I can tell. Each tensor_alloc has a buffer_id field and this is what caused me to look into this more closely, to understand what the buffer_id in leaf_alloc was used for. --- diff --git a/ggml/src/ggml-alloc.c b/ggml/src/ggml-alloc.c index 28548fbb..041de9e3 100644 --- a/ggml/src/ggml-alloc.c +++ b/ggml/src/ggml-alloc.c @@ -348,7 +348,6 @@ struct tensor_alloc { }; struct leaf_alloc { - int buffer_id; struct tensor_alloc leaf; }; @@ -740,7 +739,6 @@ bool ggml_gallocr_reserve_n(ggml_gallocr_t galloc, struct ggml_cgraph * graph, c for (int i = 0; i < graph->n_leafs; i++) { struct ggml_tensor * leaf = graph->leafs[i]; struct hash_node * hn = ggml_gallocr_hash_get(galloc, leaf); - galloc->leaf_allocs[i].buffer_id = hn->buffer_id; if (leaf->view_src || leaf->data) { galloc->leaf_allocs[i].leaf.buffer_id = -1; galloc->leaf_allocs[i].leaf.offset = SIZE_MAX;