From: Xuan-Son Nguyen Date: Thu, 28 May 2026 18:58:55 +0000 (+0200) Subject: mtmd: fix gemma 4 projector pre_norm (#23822) X-Git-Tag: upstream/0.0.10438~1038 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=c8914ad4f44e7312a8635cb52250c46cb0fe47d9;p=pkg%2Fggml%2Fsources%2Fllama.cpp mtmd: fix gemma 4 projector pre_norm (#23822) --- diff --git a/tools/mtmd/models/gemma4v.cpp b/tools/mtmd/models/gemma4v.cpp index 4068a08aa..3570d6da1 100644 --- a/tools/mtmd/models/gemma4v.cpp +++ b/tools/mtmd/models/gemma4v.cpp @@ -124,12 +124,12 @@ ggml_cgraph * clip_graph_gemma4v::build() { } // Gemma4MultimodalEmbedder - cur = build_mm(model.mm_input_proj_w, cur); - cb(cur, "projected", -1); - - // embedding_post_projection_norm - cur = ggml_rms_norm(ctx0, cur, hparams.eps); - cb(cur, "projected_normed", -1); + { + // embedding_pre_projection_norm + cur = ggml_rms_norm(ctx0, cur, hparams.eps); + cur = build_mm(model.mm_input_proj_w, cur); + cb(cur, "projected", -1); + } ggml_build_forward_expand(gf, cur); return gf;