From: Georgi Gerganov Date: Tue, 9 Sep 2025 05:42:10 +0000 (+0300) Subject: contrib : add notes about merging PRs (#15881) X-Git-Tag: upstream/0.0.6527~101 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=c252ce67c4b99f056eeb18d42a289e28fee03475;p=pkg%2Fggml%2Fsources%2Fllama.cpp contrib : add notes about merging PRs (#15881) * contrib : add notes about merging PRs * Update CONTRIBUTING.md Co-authored-by: Diego Devesa * Update CONTRIBUTING.md Co-authored-by: Johannes Gäßler --------- Co-authored-by: Diego Devesa Co-authored-by: Johannes Gäßler --- diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index e68ff924..6db74a0c 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -16,6 +16,9 @@ - Use the following format for the squashed commit title: ` : (#)`. For example: `utils : fix typo in utils.py (#1234)` - Optionally pick a `` from here: https://github.com/ggml-org/llama.cpp/wiki/Modules - Consider adding yourself to [CODEOWNERS](CODEOWNERS) +- Let authors, who are also collaborators, merge their own PRs +- When merging a PR by a contributor, make sure you have a good understanding of the changes +- Be mindful of maintenance: most of the work going into a feature happens after the PR is merged. If the PR author is not committed to contribute long-term, someone else needs to take responsibility (you) # Coding guidelines