From: Sigbjørn Skjæret <redacted>
Date: Wed, 13 May 2026 06:14:24 +0000 (+0200)
Subject: llama-eval : enable type check (#22988)
X-Git-Tag: upstream/0.0.10438~1308
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=bcfe63fc53e331b8b5f24aa5e9e9528e745cfae8;p=pkg%2Fggml%2Fsources%2Fllama.cpp

llama-eval : enable type check (#22988)
---

diff --git a/examples/llama-eval/llama-eval.py b/examples/llama-eval/llama-eval.py
index b33a3615b..a29482735 100755
--- a/examples/llama-eval/llama-eval.py
+++ b/examples/llama-eval/llama-eval.py
@@ -1,5 +1,4 @@
 #!/usr/bin/env python3
-# type: ignore
 
 import argparse
 import json
@@ -100,6 +99,8 @@ D) {D}
 
 
 class BaseDataset(ABC):
+    questions: List[Dict]
+
     @abstractmethod
     def get_question(self, index: int) -> Dict:
         pass
@@ -573,7 +574,7 @@ def normalize_number(s: str) -> Optional[int]:
 class AimeDataset(BaseDataset):
     def __init__(self, split: str = "train"):
         self.split = split
-        self.questions: List[Dict] = []
+        self.questions = []
         self._load_dataset()
 
     def _load_dataset(self):
@@ -618,7 +619,7 @@ class AimeDataset(BaseDataset):
 
 class Aime2025Dataset(BaseDataset):
     def __init__(self):
-        self.questions: List[Dict] = []
+        self.questions = []
         self._load_dataset()
 
     def _load_dataset(self):
@@ -681,7 +682,7 @@ class Aime2025Dataset(BaseDataset):
 class Gsm8kDataset(BaseDataset):
     def __init__(self, split: str = "test"):
         self.split = split
-        self.questions: List[Dict] = []
+        self.questions = []
         self._load_dataset()
 
     def _load_dataset(self):
@@ -742,7 +743,7 @@ class GpqaDataset(BaseDataset):
     def __init__(self, variant: str = "diamond", seed: int = 1234):
         self.variant = variant
         self.seed = seed
-        self.questions: List[Dict] = []
+        self.questions = []
         self._load_dataset()
 
     def _load_dataset(self):