From: Sigbjørn Skjæret Date: Sun, 17 Aug 2025 11:30:23 +0000 (+0200) Subject: ci : fix hang in windows-hip build/release (#15365) X-Git-Tag: upstream/0.0.6199~14 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=b143fbc87af0324aa49e16cd91faf3ba8bb22231;p=pkg%2Fggml%2Fsources%2Fllama.cpp ci : fix hang in windows-hip build/release (#15365) * fix hang in windows-latest-cmake-hip * apply fix to release as well --- diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 83aaea99..43553ac1 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -1070,7 +1070,8 @@ jobs: write-host "Downloading AMD HIP SDK Installer" Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-24.Q3-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe" write-host "Installing AMD HIP SDK" - Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -Wait + $proc = Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -PassThru + $proc.WaitForExit(600000) write-host "Completed AMD HIP SDK installation" - name: Verify ROCm diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 9ebb0236..5367637e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -557,7 +557,8 @@ jobs: write-host "Downloading AMD HIP SDK Installer" Invoke-WebRequest -Uri "https://download.amd.com/developer/eula/rocm-hub/AMD-Software-PRO-Edition-24.Q3-WinSvr2022-For-HIP.exe" -OutFile "${env:RUNNER_TEMP}\rocm-install.exe" write-host "Installing AMD HIP SDK" - Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -Wait + $proc = Start-Process "${env:RUNNER_TEMP}\rocm-install.exe" -ArgumentList '-install' -NoNewWindow -PassThru + $proc.WaitForExit(600000) write-host "Completed AMD HIP SDK installation" - name: Verify ROCm