From: Georgi Gerganov <redacted>
Date: Wed, 27 Nov 2024 09:22:14 +0000 (+0200)
Subject: metal : fix group_norm support condition (#0)
X-Git-Tag: upstream/0.0.4488~288
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=9e2301f4a4ef1690bd99360c11de43fe830b1c8d;p=pkg%2Fggml%2Fsources%2Fllama.cpp

metal : fix group_norm support condition (#0)
---

diff --git a/ggml/src/ggml-metal/ggml-metal.m b/ggml/src/ggml-metal/ggml-metal.m
index c47f07a9..ae6b25ed 100644
--- a/ggml/src/ggml-metal/ggml-metal.m
+++ b/ggml/src/ggml-metal/ggml-metal.m
@@ -997,9 +997,10 @@ static bool ggml_metal_supports_op(const struct ggml_backend_metal_device_contex
             return ggml_is_contiguous(op->src[0]);
         case GGML_OP_SUM_ROWS:
         case GGML_OP_SOFT_MAX:
-        case GGML_OP_RMS_NORM:
         case GGML_OP_GROUP_NORM:
             return has_simdgroup_reduction;
+        case GGML_OP_RMS_NORM:
+            return has_simdgroup_reduction && (op->ne[0] % 4 == 0);
         case GGML_OP_NORM:
         case GGML_OP_ROPE:
             return true;
@@ -2672,7 +2673,6 @@ static void ggml_metal_encode_node(
             } break;
         case GGML_OP_GROUP_NORM:
             {
-                GGML_ASSERT(ne00 % 4 == 0);
                 GGML_ASSERT(ggml_is_contiguous(src0));
 
                 float eps;