From: Adrien Gallouët Date: Thu, 4 Dec 2025 06:04:02 +0000 (+0100) Subject: build : move _WIN32_WINNT definition to headers (llama/17736) X-Git-Tag: upstream/1.8.3~195 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=92e50155c97fa8747631c847064ced65c980a4f3;p=pkg%2Fggml%2Fsources%2Fwhisper.cpp build : move _WIN32_WINNT definition to headers (llama/17736) Previously, cmake was forcing `_WIN32_WINNT=0x0A00` for MinGW builds, This caused "macro redefined" warnings with toolchains that define the version. This also removes the `GGML_WIN_VER` variable as it is no longer needed. Signed-off-by: Adrien Gallouët --- diff --git a/ggml/CMakeLists.txt b/ggml/CMakeLists.txt index db47ae8d..0ccd9019 100644 --- a/ggml/CMakeLists.txt +++ b/ggml/CMakeLists.txt @@ -175,11 +175,6 @@ option(GGML_CPU_ALL_VARIANTS "ggml: build all variants of the CPU backend (requi set(GGML_CPU_ARM_ARCH "" CACHE STRING "ggml: CPU architecture for ARM") set(GGML_CPU_POWERPC_CPUTYPE "" CACHE STRING "ggml: CPU type for PowerPC") - -if (MINGW) - set(GGML_WIN_VER "0xA00" CACHE STRING "ggml: Windows version") -endif() - # ggml core set(GGML_SCHED_MAX_COPIES "4" CACHE STRING "ggml: max input copies for pipeline parallelism") option(GGML_CPU "ggml: enable CPU backend" ON) diff --git a/ggml/include/ggml.h b/ggml/include/ggml.h index e6656146..b0e10f57 100644 --- a/ggml/include/ggml.h +++ b/ggml/include/ggml.h @@ -204,6 +204,10 @@ # define GGML_ATTRIBUTE_FORMAT(...) __attribute__((format(printf, __VA_ARGS__))) #endif +#if defined(_WIN32) && !defined(_WIN32_WINNT) +# define _WIN32_WINNT 0x0A00 +#endif + #include #include #include diff --git a/ggml/src/CMakeLists.txt b/ggml/src/CMakeLists.txt index d93664b8..98606e9c 100644 --- a/ggml/src/CMakeLists.txt +++ b/ggml/src/CMakeLists.txt @@ -127,10 +127,6 @@ if (NOT MSVC) endif() endif() -if (MINGW) - add_compile_definitions(_WIN32_WINNT=${GGML_WIN_VER}) -endif() - # # POSIX conformance #