From: Ruben Ortlam <redacted>
Date: Tue, 17 Mar 2026 20:51:43 +0000 (+0100)
Subject: vulkan: disable mmvq on Intel Windows driver (#20672)
X-Git-Tag: upstream/0.0.8611~212
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=892e3c333a634f818acc195dc699468c08ff5e80;p=pkg%2Fggml%2Fsources%2Fllama.cpp

vulkan: disable mmvq on Intel Windows driver (#20672)

* vulkan: disable mmvq on Intel Windows driver

* improve comment
---

diff --git a/ggml/src/ggml-vulkan/ggml-vulkan.cpp b/ggml/src/ggml-vulkan/ggml-vulkan.cpp
index 3d8ce1067..3e36435d1 100644
--- a/ggml/src/ggml-vulkan/ggml-vulkan.cpp
+++ b/ggml/src/ggml-vulkan/ggml-vulkan.cpp
@@ -7646,20 +7646,14 @@ static bool ggml_vk_should_use_mmvq(const vk_device& device, uint32_t m, uint32_
             return true;
         }
     case VK_VENDOR_ID_INTEL:
-        if (k < 2048) {
+        if (device->driver_id == vk::DriverId::eIntelProprietaryWindows) {
+            // Intel Windows proprietary driver MMVQ performance is worse than fp16, see
+            // https://github.com/ggml-org/llama.cpp/issues/17628
             return false;
         }
 
-        if (device->driver_id == vk::DriverId::eIntelProprietaryWindows) {
-            // Intel Windows proprietary driver tuning
-            switch (src0_type) {
-            case GGML_TYPE_MXFP4:
-            case GGML_TYPE_Q4_K:
-            case GGML_TYPE_Q5_K:
-                return false;
-            default:
-                return true;
-            }
+        if (k < 2048) {
+            return false;
         }
 
         switch (src0_type) {