From: Daniel Bevenius <redacted>
Date: Sun, 16 Mar 2025 17:22:05 +0000 (+0100)
Subject: ci : add --symlinks to xcframework zip command (#12409)
X-Git-Tag: upstream/0.0.5028~134
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=7b61bcc87cfdeab88350e82df1c4b7be64331ea6;p=pkg%2Fggml%2Fsources%2Fllama.cpp

ci : add --symlinks to xcframework zip command (#12409)

This commit adds the --symlinks option to the zip command used to create
the xcframework zip file. This is necessary to create symlinks in the
zip file. Without this option,  the Versions symlink is stored as a
regular directory entry in the zip file, rather than as a symlink in the
zip which causes the followig error in xcode:
```console
Couldn't resolve framework symlink for '/Users/danbev/work/ai/llama.cpp/tmp_1/build-apple/llama.xcframework/macos-arm64_x86_64/llama.framework/Versions/Current': readlink(/Users/danbev/work/ai/llama.cpp/tmp_1/build-apple/llama.xcframework/macos-arm64_x86_64/llama.framework/Versions/Current): Invalid argument (22)
```

Refs: https://github.com/ggml-org/llama.cpp/pull/11996#issuecomment-2727026377
---

diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
index 1e242936..03cde0a4 100644
--- a/.github/workflows/build.yml
+++ b/.github/workflows/build.yml
@@ -1379,7 +1379,7 @@ jobs:
         id: pack_artifacts
         if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}
         run: |
-          zip -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
+          zip --symlinks -r llama-${{ steps.tag.outputs.name }}-xcframework.zip build-apple/llama.xcframework
 
       - name: Upload artifacts
         if: ${{ ( github.event_name == 'push' && github.ref == 'refs/heads/master' ) || github.event.inputs.create_release == 'true' }}