From: Herman Semenov Date: Fri, 22 Dec 2023 09:26:49 +0000 (+0000) Subject: ggml : add comment about backward GGML_OP_DIAG_MASK_INF (#4203) X-Git-Tag: upstream/0.0.4488~2801 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=48b24b170e3b4f9dc28200306840cb07d1c123df;p=pkg%2Fggml%2Fsources%2Fllama.cpp ggml : add comment about backward GGML_OP_DIAG_MASK_INF (#4203) --- diff --git a/ggml.c b/ggml.c index f27920a2..15e1984d 100644 --- a/ggml.c +++ b/ggml.c @@ -15335,6 +15335,8 @@ static void ggml_compute_backward(struct ggml_context * ctx, struct ggml_tensor const int n_past = ((int32_t *) tensor->op_params)[0]; src0->grad = ggml_add_or_set(ctx, src0->grad, + /* ggml_diag_mask_inf_impl() shouldn't be here */ + /* ref: https://github.com/ggerganov/llama.cpp/pull/4203#discussion_r1412377992 */ ggml_diag_mask_zero_impl(ctx, tensor->grad, n_past, false), zero_table); }