From: mtmcp <redacted>
Date: Fri, 27 Mar 2026 08:25:58 +0000 (-0300)
Subject: completion : session_tokens insert range in completion tool (no-op → correct) (#20917)
X-Git-Tag: upstream/0.0.8611~60
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=37f230dd7cff6732580bec976ca9e378af230d20;p=pkg%2Fggml%2Fsources%2Fllama.cpp

completion : session_tokens insert range in completion tool (no-op → correct) (#20917)

The embd.begin(), embd.begin() range is empty and inserts nothing, so session_tokens never gets updated after
  decoding. Should be embd.begin(), embd.end(). Introduced in commit 2b6dfe8.
---

diff --git a/tools/completion/completion.cpp b/tools/completion/completion.cpp
index a24482956..716a30fe9 100644
--- a/tools/completion/completion.cpp
+++ b/tools/completion/completion.cpp
@@ -701,7 +701,7 @@ int main(int argc, char ** argv) {
                 if (!common_prompt_batch_decode(ctx, embd, n_past, params.n_batch, path_session, save_now)) {
                     return 1;
                 }
-                session_tokens.insert(session_tokens.end(), embd.begin(), embd.begin());
+                session_tokens.insert(session_tokens.end(), embd.begin(), embd.end());
                 n_session_consumed = session_tokens.size();
                 session_do_save = false;