From: Ed Lee <redacted>
Date: Sun, 3 Dec 2023 09:10:43 +0000 (-0800)
Subject: server : fix OpenAI API `stop` field to be optional (#4299)
X-Git-Tag: upstream/0.0.4488~2883
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=33e171d1e9fc4903f9314b490d77fb8d58331b63;p=pkg%2Fggml%2Fsources%2Fllama.cpp

server : fix OpenAI API `stop` field to be optional (#4299)

(cherry picked from commit Mozilla-Ocho/llamafile@e8c92bcb84ae3bcbf0d617b7ee6a5413bcbd58af)
---

diff --git a/examples/server/server.cpp b/examples/server/server.cpp
index 0fd42dcb..911f7bbe 100644
--- a/examples/server/server.cpp
+++ b/examples/server/server.cpp
@@ -2410,9 +2410,7 @@ json oaicompat_completion_params_parse(
     }
 
     // Handle 'stop' field
-    if (body["stop"].is_null()) {
-        llama_params["stop"] = json::array({});
-    } else if (body["stop"].is_string()) {
+    if (body.contains("stop") && body["stop"].is_string()) {
         llama_params["stop"] = json::array({body["stop"].get<std::string>()});
     } else {
         llama_params["stop"] = json_value(body, "stop", json::array());