From: Stephan Walter <redacted>
Date: Sat, 15 Apr 2023 18:28:56 +0000 (+0000)
Subject: Fix potential int8 overflow in non-SIMD vec_dot (#986)
X-Git-Tag: gguf-v0.4.0~947
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=2f7c8e014e3c0ceaf39688845c2ff6f919fb03b7;p=pkg%2Fggml%2Fsources%2Fllama.cpp

Fix potential int8 overflow in non-SIMD vec_dot (#986)
---

diff --git a/ggml.c b/ggml.c
index ccad76e8..69974989 100644
--- a/ggml.c
+++ b/ggml.c
@@ -2373,11 +2373,11 @@ static void ggml_vec_dot_q4_0(const int n, float * restrict s, const void * rest
             const uint8_t v0 = p0[j];
             const uint8_t v1 = p1[j];
 
-            const int8_t i0 = (int8_t) (v0 & 0xf) - 8;
-            const int8_t i1 = (int8_t) (v0 >> 4)  - 8;
+            const int i0 = (v0 & 0xf) - 8;
+            const int i1 = (v0 >> 4)  - 8;
 
-            const int8_t i2 = (int8_t) (v1 & 0xf) - 8;
-            const int8_t i3 = (int8_t) (v1 >> 4)  - 8;
+            const int i2 = (v1 & 0xf) - 8;
+            const int i3 = (v1 >> 4)  - 8;
 
             sumi += i0*i2 + i1*i3;
         }