From: marcoStocchi Date: Fri, 10 Jul 2026 09:52:20 +0000 (+0200) Subject: cli: fix crash on wrong server base url (#25497) X-Git-Tag: upstream/0.0.10438~482 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=1b9691bcd5c61d3ffb9bcf5bafb1c20a4d47cf08;p=pkg%2Fggml%2Fsources%2Fllama.cpp cli: fix crash on wrong server base url (#25497) * llama-cli: fix crash on wrong server base url by catching exceptions and graceful exit * review: leaner catch group: json error and standard exception --- diff --git a/tools/cli/cli-context.cpp b/tools/cli/cli-context.cpp index 74d60eb19..0de8f6902 100644 --- a/tools/cli/cli-context.cpp +++ b/tools/cli/cli-context.cpp @@ -153,9 +153,19 @@ bool cli_context::init() { if (use_external_server) { spinner.reset(); - if (!list_and_ask_models()) { + try { + if (!list_and_ask_models()) { + return false; + } + } catch (const json::parse_error & e) { + ui::show_error(e.what()); + ui::show_message("This might be caused by an incorrect server-base endpoint URL"); + return false; + } catch (const std::exception & e) { + ui::show_error(e.what()); return false; } + // restore the spinner for the next step spinner.emplace("Waiting for server..."); }