From: kalomaze <redacted>
Date: Fri, 2 Feb 2024 14:15:30 +0000 (-0600)
Subject: perplexity : fix KL divergence calculations on Windows (#5273)
X-Git-Tag: upstream/0.0.4488~2437
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=191221178f51b6e81122c5bda0fd79620e547d07;p=pkg%2Fggml%2Fsources%2Fllama.cpp

perplexity : fix KL divergence calculations on Windows (#5273)
---

diff --git a/examples/perplexity/perplexity.cpp b/examples/perplexity/perplexity.cpp
index 8d220496..4b08145c 100644
--- a/examples/perplexity/perplexity.cpp
+++ b/examples/perplexity/perplexity.cpp
@@ -457,14 +457,14 @@ static results_perplexity perplexity(llama_context * ctx, const gpt_params & par
 
     std::ofstream logits_stream;
     if (!params.logits_file.empty()) {
-        logits_stream.open(params.logits_file.c_str());
+        logits_stream.open(params.logits_file.c_str(), std::ios::binary);
         if (!logits_stream.is_open()) {
             fprintf(stderr, "%s: failed to open %s for writing\n", __func__, params.logits_file.c_str());
             return {};
         }
         fprintf(stderr, "%s: saving all logits to %s\n", __func__, params.logits_file.c_str());
         logits_stream.write("_logits_", 8);
-        logits_stream.write((const char *)&n_ctx, sizeof(n_ctx));
+        logits_stream.write(reinterpret_cast<const char *>(&n_ctx), sizeof(n_ctx));
     }
 
     auto tim1 = std::chrono::high_resolution_clock::now();