From: texasich Date: Sun, 19 Apr 2026 07:25:05 +0000 (-0500) Subject: cmake: remove CMP0194 policy to restore MSVC builds (#21934) X-Git-Tag: upstream/0.0.10438~1595 X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=09b4efa95f8223f6d168f046c80fe4529a68117b;p=pkg%2Fggml%2Fsources%2Fllama.cpp cmake: remove CMP0194 policy to restore MSVC builds (#21934) #21630 added the CMP0194 NEW policy to silence a CMake warning, but on Windows runners it caused CMake to prefer the MinGW toolchain for ASM and broke MSVC builds. Reverting only that policy block restores the previous working behavior. The CMake 4.1+ warning comes back, but that is cosmetic and does not break any platform. Reported-by: oobabooga Refs: #21630 Co-authored-by: texasich --- diff --git a/ggml/CMakeLists.txt b/ggml/CMakeLists.txt index 6b65ecd6e..a0eb9204e 100644 --- a/ggml/CMakeLists.txt +++ b/ggml/CMakeLists.txt @@ -1,11 +1,5 @@ cmake_minimum_required(VERSION 3.14...3.28) # for add_link_options and implicit target directories. -# ref: https://cmake.org/cmake/help/latest/policy/CMP0194.html -# MSVC is not a valid assembler for the ASM language. -# Set to NEW to avoid a warning on CMake 4.1+ with MSVC. -if (POLICY CMP0194) - cmake_policy(SET CMP0194 NEW) -endif() project("ggml" C CXX ASM) ### GGML Version