From: Jeff Bolz <redacted>
Date: Wed, 12 Mar 2025 05:59:19 +0000 (-0500)
Subject: vulkan: fix bug in coopmat1 mul_mat_id (llama/12316)
X-Git-Tag: upstream/1.7.5~93
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=08f32992d0508f664348786e1f256d94a699dbf8;p=pkg%2Fggml%2Fsources%2Fwhisper.cpp

vulkan: fix bug in coopmat1 mul_mat_id (llama/12316)

* tests: run mul_mat_id with a larger N

* vulkan: fix bug in coopmat1 mul_mat_id
---

diff --git a/ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp b/ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp
index a8fd93fd..0d03411f 100644
--- a/ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp
+++ b/ggml/src/ggml-vulkan/vulkan-shaders/mul_mm.comp
@@ -777,7 +777,7 @@ void main() {
         [[unroll]] for (uint cm_col = 0; cm_col < cms_per_col; cm_col++) {
             coopMatStore(sums[cm_col * cms_per_row + cm_row], coopmat_stage, warp_i * TM * TN, TM, gl_CooperativeMatrixLayoutColumnMajor);
 
-            [[unroll]] for (uint col = 0; col < BN; col += storestride) {
+            [[unroll]] for (uint col = 0; col < TN; col += storestride) {
                 const uint row_i = dc + cm_col * TN + col + store_c;
                 if (row_i >= _ne1) break;