From: Justin Santa Barbara <redacted>
Date: Thu, 1 May 2025 21:32:11 +0000 (-0400)
Subject: rpc : avoid uninitialized memory in serialize_tensor (llama/13210)
X-Git-Tag: upstream/0.0.2015~3
X-Git-Url: https://git.djapps.eu/?a=commitdiff_plain;h=08036d4a2a2cdec11606042af6b02c5bf6d22c80;p=pkg%2Fggml%2Fsources%2Fggml

rpc : avoid uninitialized memory in serialize_tensor (llama/13210)

Zero out the name and padding buffers.
---

diff --git a/src/ggml-rpc/ggml-rpc.cpp b/src/ggml-rpc/ggml-rpc.cpp
index 140a775f..e662cc6e 100644
--- a/src/ggml-rpc/ggml-rpc.cpp
+++ b/src/ggml-rpc/ggml-rpc.cpp
@@ -518,6 +518,11 @@ static rpc_tensor serialize_tensor(const ggml_tensor * tensor) {
     result.view_src = reinterpret_cast<uint64_t>(tensor->view_src);
     result.view_offs = tensor->view_offs;
     result.data = reinterpret_cast<uint64_t>(tensor->data);
+
+    // Avoid sending uninitialized data over the wire
+    memset(result.name, 0, sizeof(result.name));
+    memset(result.padding, 0, sizeof(result.padding));
+
     snprintf(result.name, GGML_MAX_NAME, "%s", tensor->name);
     return result;
 }