]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
Update ggml/src/gguf.cpp : Defined virtual keyword for destructor of gguf_writer_base...
authorYongmin Yoo 유용민 <redacted>
Sat, 25 Jul 2026 12:32:37 +0000 (21:32 +0900)
committerGitHub <redacted>
Sat, 25 Jul 2026 12:32:37 +0000 (14:32 +0200)
Without a virtual destructor, deleting a derived object through a
base-class pointer only invokes the base destructor, skipping the
derived one.

ggml/src/gguf.cpp

index 7920b8100b61e2f2d903f55e7e0887fc07b65d4b..9f9e4fe5d104fe753e9fbc646efb231c3d78ee76 100644 (file)
@@ -1424,7 +1424,7 @@ void gguf_set_tensor_data(struct gguf_context * ctx, const char * name, const vo
 struct gguf_writer_base {
     size_t written_bytes {0u};
 
-    ~gguf_writer_base(void) = default;
+    virtual ~gguf_writer_base(void) = default;
 
     // we bet on devirtualization
     virtual void write(int8_t val) = 0;