]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
model-conversion : remove max diff check in compare-logits [no ci] (#17954)
authorDaniel Bevenius <redacted>
Fri, 12 Dec 2025 12:25:16 +0000 (13:25 +0100)
committerGitHub <redacted>
Fri, 12 Dec 2025 12:25:16 +0000 (13:25 +0100)
This commit removes the maximum difference check from the
compare-logits.py which would stop early if the difference between
the logits exceeded a threshold.

The motivation for removing this is that it can be useful to be able to
get the complete log for debugging/reporting purposes.

examples/model-conversion/scripts/causal/compare-logits.py

index afa0d5b263a0d0b0fb96f4b6156642ad56d84f24..27447890996718227eef5e27829ae57b778fc5e2 100755 (executable)
@@ -32,10 +32,6 @@ def quick_logits_check(pytorch_file, llamacpp_file):
     print(f"Top 10 llama.cpp logits: {llamacpp_logits[llamacpp_top10]}")
     print(f"Max absolute difference: {max_diff:.4f}")
 
-    if max_diff > 1.0:
-        print(f"❌ NOK: Large differences detected - max diff: {max_diff:.4f}")
-        return False
-
     return True
 
 def main():