]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
llama-eval : fix crash when answer is None in HTML dump (#25435)
authorGeorgi Gerganov <redacted>
Wed, 8 Jul 2026 07:00:03 +0000 (10:00 +0300)
committerGitHub <redacted>
Wed, 8 Jul 2026 07:00:03 +0000 (10:00 +0300)
dict.get("key", default) returns None (not default) when the key
exists but its value is explicitly None. This caused an AttributeError
in _escape_html() when a task errored before grading and answer was
set to None.

Assisted-by: pi:llama.cpp/Qwen3.6-27B
examples/llama-eval/llama-eval.py

index 4bdd239c0078e00bdef21e4780487943f56eb8a8..61bdbddd8b13beda9e620e13d15220552372afd5 100755 (executable)
@@ -362,7 +362,7 @@ class EvalState:
             case = cases.get(task_id, {})
             status = case.get("status", "pending")
             expected = case.get("expected", "")
-            answer = case.get("answer", "") if status == "ok" else ""
+            answer = case.get("answer") or "" if status == "ok" else ""
             is_correct = case.get("correct", False) if status == "ok" else False
             response = case.get("response", "") or ""
             prompt = case.get("prompt", "") or ""
@@ -647,7 +647,7 @@ class EvalState:
             question, prompt, expected = self.get_case(i)
             case = cases.get(task_id, {})
             status = case.get("status", "pending")
-            answer = case.get("answer", "N/A") if status == "ok" else "N/A"
+            answer = case.get("answer") or "N/A" if status == "ok" else "N/A"
             tokens = case.get("tokens")
             tokens_str = str(tokens) if tokens is not None else "N/A"
             tps_gen = case.get("tps_gen")