]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
mtmd: fix gemma 4 projector pre_norm (#23822)
authorXuan-Son Nguyen <redacted>
Thu, 28 May 2026 18:58:55 +0000 (20:58 +0200)
committerGitHub <redacted>
Thu, 28 May 2026 18:58:55 +0000 (20:58 +0200)
tools/mtmd/models/gemma4v.cpp

index 4068a08aaf97f37d9967542576881211911e57b9..3570d6da13516c81de052a977b115d12973fcb64 100644 (file)
@@ -124,12 +124,12 @@ ggml_cgraph * clip_graph_gemma4v::build() {
     }
 
     // Gemma4MultimodalEmbedder
-    cur = build_mm(model.mm_input_proj_w, cur);
-    cb(cur, "projected", -1);
-
-    // embedding_post_projection_norm
-    cur = ggml_rms_norm(ctx0, cur, hparams.eps);
-    cb(cur, "projected_normed", -1);
+    {
+        // embedding_pre_projection_norm
+        cur = ggml_rms_norm(ctx0, cur, hparams.eps);
+        cur = build_mm(model.mm_input_proj_w, cur);
+        cb(cur, "projected", -1);
+    }
 
     ggml_build_forward_expand(gf, cur);
     return gf;