]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
musa: bump MUSA SDK version to rc3.1.1 (#11822)
authorR0CKSTAR <redacted>
Thu, 13 Feb 2025 12:28:18 +0000 (20:28 +0800)
committerGitHub <redacted>
Thu, 13 Feb 2025 12:28:18 +0000 (13:28 +0100)
* musa: Update MUSA SDK version to rc3.1.1

Signed-off-by: Xiaodong Ye <redacted>
* musa: Remove workaround in PR #10042

Signed-off-by: Xiaodong Ye <redacted>
---------

Signed-off-by: Xiaodong Ye <redacted>
.devops/musa.Dockerfile
.github/workflows/build.yml
docs/docker.md
ggml/src/ggml-cuda/ggml-cuda.cu

index bfd7fc1c1740fd5898a8576b5b7e13b6a79d68a0..1e87737abfb71bf9295cc246fa93a44724a15ce2 100644 (file)
@@ -1,6 +1,6 @@
 ARG UBUNTU_VERSION=22.04
 # This needs to generally match the container host's environment.
-ARG MUSA_VERSION=rc3.1.0
+ARG MUSA_VERSION=rc3.1.1
 # Target the MUSA build image
 ARG BASE_MUSA_DEV_CONTAINER=mthreads/musa:${MUSA_VERSION}-devel-ubuntu${UBUNTU_VERSION}
 
index 6841ba5897809a89fab24d80174106ddad7b54ca..02f6a13634b3f7e949a3c82ede8aa80b923b35bb 100644 (file)
@@ -443,7 +443,7 @@ jobs:
 
   ubuntu-22-cmake-musa:
     runs-on: ubuntu-22.04
-    container: mthreads/musa:rc3.1.0-devel-ubuntu22.04
+    container: mthreads/musa:rc3.1.1-devel-ubuntu22.04
 
     steps:
       - name: Clone
index dac9a9ec164ffe103c8d6f8ddf0c9a7cb6cec8d1..cab5ae95723496063d996a3419850773f17eaa3e 100644 (file)
@@ -104,7 +104,7 @@ You may want to pass in some different `ARGS`, depending on the MUSA environment
 
 The defaults are:
 
-- `MUSA_VERSION` set to `rc3.1.0`
+- `MUSA_VERSION` set to `rc3.1.1`
 
 The resulting images, are essentially the same as the non-MUSA images:
 
index 6ea41577768c3ce9f7b904ab6d1e2292b675d06b..093ad70991b5a208f15db32c100ac91e1babfa04 100644 (file)
@@ -1480,12 +1480,7 @@ static void ggml_cuda_op_mul_mat(
             const size_t nbytes_data    = ggml_nbytes(src0);
             const size_t nbytes_padding = ggml_row_size(src0->type, MATRIX_ROW_PADDING - ne00 % MATRIX_ROW_PADDING);
             dev[id].src0_dd = dev[id].src0_dd_alloc.alloc(ctx.pool(id), nbytes_data + nbytes_padding);
-        // TODO: remove this for MUSA once the Guilty Lockup issue is resolved
-#ifndef GGML_USE_MUSA
             CUDA_CHECK(cudaMemsetAsync(dev[id].src0_dd, 0, nbytes_data + nbytes_padding, stream));
-#else // GGML_USE_MUSA
-            CUDA_CHECK(cudaMemsetAsync(dev[id].src0_dd + nbytes_data, 0, nbytes_padding, stream));
-#endif // !GGML_USE_MUSA
         }
 
         // If src0 is on a temporary compute buffer (partial offloading) there may be some padding that needs to be cleared: