]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
llama : correct rms norm for llama 4 (#12882)
authorXuan-Son Nguyen <redacted>
Fri, 11 Apr 2025 06:49:50 +0000 (08:49 +0200)
committerGitHub <redacted>
Fri, 11 Apr 2025 06:49:50 +0000 (08:49 +0200)
src/llama-model.cpp

index 9e4166a71c6413c37d96e164178621269e4239cb..ff847701e99de87c723d56d6d6e21b897c4a89e5 100644 (file)
@@ -4440,8 +4440,8 @@ struct llm_build_llama : public llm_graph_context {
 
                 if (arch == LLM_ARCH_LLAMA4 && use_rope && hparams.use_kq_norm) {
                     // Llama4TextL2Norm
-                    Qcur = ggml_rms_norm(ctx0, Qcur, 1e-6);
-                    Kcur = ggml_rms_norm(ctx0, Kcur, 1e-6);
+                    Qcur = ggml_rms_norm(ctx0, Qcur, hparams.f_norm_rms_eps);
+                    Kcur = ggml_rms_norm(ctx0, Kcur, hparams.f_norm_rms_eps);
                     cb(Qcur, "Qcur_normed", il);
                     cb(Kcur, "Kcur_normed", il);
                 }