]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
HIP: flip GGML_HIP_GRAPHS to default on (#22254)
authoruvos <redacted>
Thu, 23 Apr 2026 00:34:31 +0000 (02:34 +0200)
committerGitHub <redacted>
Thu, 23 Apr 2026 00:34:31 +0000 (02:34 +0200)
In #11362 hip graph was disabled by default as, at the time, its performance impact was negative. Due to improvements in rocm and our usage and construction of graphs this is no longer true, so lets change the default.

ggml/CMakeLists.txt

index 2effd587b41ebfa6650c14ffecd8797ae751f731..b9f7deb150d47c2cc6e4aed307c739ff0b3cc287 100644 (file)
@@ -213,7 +213,7 @@ set   (GGML_CUDA_COMPRESSION_MODE "size" CACHE STRING
 set_property(CACHE GGML_CUDA_COMPRESSION_MODE PROPERTY STRINGS "none;speed;balance;size")
 
 option(GGML_HIP                             "ggml: use HIP"                                   OFF)
-option(GGML_HIP_GRAPHS                      "ggml: use HIP graph, experimental, slow"         OFF)
+option(GGML_HIP_GRAPHS                      "ggml: use HIP graph"                              ON)
 option(GGML_HIP_RCCL                        "ggml: use ROCm Collective Comm. Library"         OFF)
 option(GGML_HIP_NO_VMM                      "ggml: do not try to use HIP VMM"                 ON)
 option(GGML_HIP_ROCWMMA_FATTN               "ggml: enable rocWMMA for FlashAttention"         OFF)