]> git.djapps.eu Git - pkg/ggml/sources/ggml/commitdiff
clip : fix pixtral on some GPU backends (llama/13097)
authorXuan-Son Nguyen <redacted>
Fri, 25 Apr 2025 12:31:42 +0000 (14:31 +0200)
committerGeorgi Gerganov <redacted>
Thu, 1 May 2025 07:39:34 +0000 (10:39 +0300)
* clip : fix pixtral on some GPU backends

* refactor inp_raw set

* rm outdated comment

* fix dynamic size

* add TODO

tests/test-backend-ops.cpp

index 61751755b317b435c0e04d3e0e765ad590ef482d..d70acb77194352ac366634917d94471ffd3999a9 100644 (file)
@@ -2606,6 +2606,8 @@ struct test_rope : public test_case {
             } else {
                 out = ggml_rope_ext_back(ctx, a, pos, freq, n_dims, mode, 0, 10000.0f, fs, ef, af, 1.0f, 1.0f);
             }
+
+            // TODO: add test with a non-contiguous view as input ; this case is needed for build_rope_2d in clip.cpp
         }
         ggml_set_name(out, "out");