]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
llava : remove prog parameter from ArgumentParser (#5457)
authorDaniel Bevenius <redacted>
Mon, 12 Feb 2024 08:38:44 +0000 (09:38 +0100)
committerGitHub <redacted>
Mon, 12 Feb 2024 08:38:44 +0000 (10:38 +0200)
* llava: remove prog parameter from ArgumentParser

This commit removes the `prog` parameter from `ArgumentParser`
so that it uses the default value which is the name of the script.

The motivation for this change is that currently the usage output looks
like this:
```console
$ python examples/llava/convert-image-encoder-to-gguf.py --help
usage: convert_hf_to_gguf.py [-h] ...
```
And with this change it will look like this:
```console
$ python examples/llava/convert-image-encoder-to-gguf.py --help
usage: convert-image-encoder-to-gguf.py [-h] ...
```

Signed-off-by: Daniel Bevenius <redacted>
* ci: add W503 to flake8 ignore list

This commit adds W503 to the ignore list for flake8. This is done to
avoid the following error:
W503 line break before binary operator

Signed-off-by: Daniel Bevenius <redacted>
---------

Signed-off-by: Daniel Bevenius <redacted>
.github/workflows/python-lint.yml
examples/llava/convert-image-encoder-to-gguf.py

index 56d17b66cecf19dd9b346605f82e74cb271d67e4..ea0a05ea1a014f6709055ba74323bf67e0f70d26 100644 (file)
@@ -16,5 +16,5 @@ jobs:
       - name: flake8 Lint
         uses: py-actions/flake8@v2
         with:
-            ignore: "E203,E211,E221,E225,E231,E241,E251,E261,E266,E501,E701,E704"
+            ignore: "E203,E211,E221,E225,E231,E241,E251,E261,E266,E501,E701,E704,W503"
             exclude: "examples/*,examples/*/**,*/**/__init__.py"
index f5a3c9b46f9e355c8ae0339c07b42b831bc4a7d5..e204b56be90be5db6488a6158fd0703f07bff436 100644 (file)
@@ -71,7 +71,7 @@ def bytes_to_unicode():
     return dict(zip(bs, cs))
 
 
-ap = argparse.ArgumentParser(prog="convert_hf_to_gguf.py")
+ap = argparse.ArgumentParser()
 ap.add_argument("-m", "--model-dir", help="Path to model directory cloned from HF Hub", required=True)
 ap.add_argument("--use-f32", action="store_true", default=False, help="Use f32 instead of f16")
 ap.add_argument("--text-only", action="store_true", required=False,