]> git.djapps.eu Git - pkg/ggml/sources/ggml/commitdiff
ggml : memset dst to 0 in `ggml_conv_transpose_1d` and `ggml_conv_transpose_2d` ...
authorPAB <redacted>
Tue, 24 Oct 2023 16:37:06 +0000 (18:37 +0200)
committerGitHub <redacted>
Tue, 24 Oct 2023 16:37:06 +0000 (19:37 +0300)
* wrong indexation of kernel buffer

* memset in dst

* apply same fix to ggml_conv_transpose_2d

src/ggml.c

index 2d3c7b8018503d9c1c4b3ee2b0faf3dcdb17ab28..f71cfd8da465ccd520bd9df124c16a9fcd7e3b60 100644 (file)
@@ -14315,6 +14315,9 @@ static void ggml_compute_forward_conv_transpose_1d_f16_f32(
             }
         }
 
+        // need to zero dst since we are accumulating into it
+        memset(dst->data, 0, ggml_nbytes(dst));
+
         return;
     }
 
@@ -14387,7 +14390,7 @@ static void ggml_compute_forward_conv_transpose_1d_f32(
                     const float * const src = (float *)((char *) src0->data + i02*nb02 + i01*nb01);
                     float * dst_data = wdata + i01*ne00*ne02;
                     for (int64_t i00 = 0; i00 < ne00; i00++) {
-                        dst_data[i01*ne00*ne02 + i00*ne02 + i02] = src[i00];
+                        dst_data[i00*ne02 + i02] = src[i00];
                     }
                 }
             }
@@ -14406,6 +14409,9 @@ static void ggml_compute_forward_conv_transpose_1d_f32(
             }
         }
 
+        // need to zero dst since we are accumulating into it
+        memset(dst->data, 0, ggml_nbytes(dst));
+
         return;
     }
 
@@ -14844,6 +14850,8 @@ static void ggml_compute_forward_conv_transpose_2d(
             }
         }
 
+        memset(dst->data, 0, ggml_nbytes(dst));
+
         return;
     }