]> git.djapps.eu Git - pkg/ggml/sources/ggml/commitdiff
vulkan: enable Conv2D for Apple after MoltenVK fixed the bug (llama/15526)
authorRuben Ortlam <redacted>
Sun, 24 Aug 2025 08:48:53 +0000 (10:48 +0200)
committerGeorgi Gerganov <redacted>
Fri, 5 Sep 2025 09:54:02 +0000 (12:54 +0300)
src/ggml-vulkan/ggml-vulkan.cpp

index 2c8d9ecaa0a0366feac0a992daa1cdd00f35d0cb..c77d1d32a0695dca38cadf4fb98ba6832bd80f34 100644 (file)
@@ -11853,14 +11853,13 @@ static bool ggml_backend_vk_device_supports_op(ggml_backend_dev_t dev, const ggm
                 // Op is disabled for Apple because it segfaults at pipeline create time on MoltenVK
                 ggml_backend_vk_device_context * ctx = (ggml_backend_vk_device_context *)dev->context;
                 const vk_device& device = ggml_vk_get_device(ctx->device);
-                bool is_Apple = ggml_vk_get_device(ctx->device)->vendor_id == VK_VENDOR_ID_APPLE;
                 // Channel-contiguous format is not supported yet.
                 return ((op->src[0]->type == GGML_TYPE_F32 || op->src[0]->type == GGML_TYPE_F16) &&
                     op->src[1]->type == GGML_TYPE_F32 &&
                     op->type == GGML_TYPE_F32 &&
                     ggml_is_contiguous(op->src[0]) &&
                     ggml_is_contiguous(op->src[1]) &&
-                    ggml_is_contiguous(op)) && !is_Apple;
+                    ggml_is_contiguous(op));
             }
         default:
             return false;