]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commitdiff
cmake: remove CMP0194 policy to restore MSVC builds (#21934)
authortexasich <redacted>
Sun, 19 Apr 2026 07:25:05 +0000 (02:25 -0500)
committerGitHub <redacted>
Sun, 19 Apr 2026 07:25:05 +0000 (10:25 +0300)
#21630 added the CMP0194 NEW policy to silence a CMake warning, but on Windows runners it caused CMake to prefer the MinGW toolchain for ASM and broke MSVC builds.

Reverting only that policy block restores the previous working behavior. The CMake 4.1+ warning comes back, but that is cosmetic and does not break any platform.

Reported-by: oobabooga
Refs: #21630

Co-authored-by: texasich <redacted>
ggml/CMakeLists.txt

index 6b65ecd6e5c4d4fbad72d915249a7f096251e55b..a0eb9204eab0430bb93717a8116415ebc80bc423 100644 (file)
@@ -1,11 +1,5 @@
 cmake_minimum_required(VERSION 3.14...3.28) # for add_link_options and implicit target directories.
 
-# ref: https://cmake.org/cmake/help/latest/policy/CMP0194.html
-# MSVC is not a valid assembler for the ASM language.
-# Set to NEW to avoid a warning on CMake 4.1+ with MSVC.
-if (POLICY CMP0194)
-    cmake_policy(SET CMP0194 NEW)
-endif()
 project("ggml" C CXX ASM)
 
 ### GGML Version