]> git.djapps.eu Git - pkg/ggml/sources/ggml/commit
ggml : prevent builds with -ffinite-math-only (llama/7726)
authorGeorgi Gerganov <redacted>
Tue, 4 Jun 2024 07:01:09 +0000 (10:01 +0300)
committerGeorgi Gerganov <redacted>
Sat, 15 Jun 2024 19:05:47 +0000 (22:05 +0300)
commitf3c91f633082ee5b43cb7aaba72a9f835dcb7482
treebc053ff91fc35615e1a76ce1b23c32e15b82ccdc
parent8d8d6b1f922fe3c69b8e7f2a3bfa9ebb2f4c8a0f
ggml : prevent builds with -ffinite-math-only (llama/7726)

This enforces a check that -fno-finite-math-only was set and that the operating
compiling mode is not in finite maths mode. This is because during rewriting of
silu and softmax for cpu #7154 there emerged an issue where the result that was
observed when >1 slot was nondeterministic as found by @JohannesGaessler.

@LostRuins narrowed the problem down to -ffinite-math-only which was theorised
to be due to SiLU, instead of flushing small values to 0, returns NaN or some
other garbage. @jart proposed a fix that @ggerganov then implemented in this fix

ref https://github.com/ggerganov/llama.cpp/pull/7154#issuecomment-2145661825
src/ggml.c