]> git.djapps.eu Git - pkg/ggml/sources/ggml/commit
vulkan : argsort barriers must be under uniform control flow (#951)
authorSalvatore Mesoraca <redacted>
Thu, 26 Sep 2024 06:59:42 +0000 (08:59 +0200)
committerGitHub <redacted>
Thu, 26 Sep 2024 06:59:42 +0000 (09:59 +0300)
commite6643c66e8e46347898a62e64705ab9bb01d42ce
treebcb4206849f03871fb7f502653a92f8aa14943f6
parent5d80b25acc1e0fb1519c0b2faa7a2f5cc31570d1
vulkan : argsort barriers must be under uniform control flow (#951)

a return before a barrier (that happens only in some threads in
a workgroup) leads to UB.
While the old code actually works on some devices,
it fails on some others (i.e. "smaller" GPUs).

BTW, I think it would be better to set specialization constants
when the graph is built, in that way the local workgroup
could be sized appropriately.
But it would take a lot of work.

Signed-off-by: Salvatore Mesoraca <redacted>
src/vulkan-shaders/argsort.comp