]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commit
ggml : prevent builds with -ffinite-math-only (#7726)
authorGeorgi Gerganov <redacted>
Tue, 4 Jun 2024 07:01:09 +0000 (10:01 +0300)
committerGitHub <redacted>
Tue, 4 Jun 2024 07:01:09 +0000 (17:01 +1000)
commit6d1616944d9efd342ed2a4fd318722adfc9febcd
treec3489076646472b4eed1ed116a6443e345611ba0
parentbde7cd3cd949c1a85d3a199498ac98e78039d46f
ggml : prevent builds with -ffinite-math-only (#7726)

This enforces a check that -fno-finite-math-only was set and that the operating
compiling mode is not in finite maths mode. This is because during rewriting of
silu and softmax for cpu #7154 there emerged an issue where the result that was
observed when >1 slot was nondeterministic as found by @JohannesGaessler.

@LostRuins narrowed the problem down to -ffinite-math-only which was theorised
to be due to SiLU, instead of flushing small values to 0, returns NaN or some
other garbage. @jart proposed a fix that @ggerganov then implemented in this fix

ref https://github.com/ggerganov/llama.cpp/pull/7154#issuecomment-2145661825
cmake/arm64-windows-llvm.cmake
ggml.c