]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commit
common: fix missing exports in llama-common (#22340)
authorMax Krasnyansky <redacted>
Mon, 27 Apr 2026 05:06:39 +0000 (22:06 -0700)
committerGitHub <redacted>
Mon, 27 Apr 2026 05:06:39 +0000 (08:06 +0300)
commit5594d132244aeb1bae54dd431e7efbc908f5e3b8
tree3267fd94c9a44111d0e2b8253c8870c15b9f39a2
parentf53577432541bb9edc1588c4ef45c66bf07e4468
common: fix missing exports in llama-common (#22340)

* common: refactor common/debug to move abort_on_nan into base_callback_data

Passing bool abort_on_nan as template parameter for common_debug_cb_eval is unnecessary and creates an issue with LTO.
It should just be a member of the base_callback_data instead.

* cont : cleanup

* common : use pimpl in debug.h to reduce header dependencies

Move common_debug_cb_user_data's data members (std::regex,
std::vector<uint8_t>) into a private impl struct in debug.cpp.

This removes the includes of common.h and <regex> from debug.h,
reducing transitive dependencies for any translation unit that
includes the header.

Assisted-by: llama.cpp:local pi
---------

Co-authored-by: Georgi Gerganov <redacted>
common/debug.cpp
common/debug.h
examples/debug/debug.cpp
examples/eval-callback/eval-callback.cpp
tools/mtmd/debug/mtmd-debug.cpp
tools/mtmd/mtmd-cli.cpp