]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commit
vulkan : argsort barriers must be under uniform control flow (ggml/951)
authorSalvatore Mesoraca <redacted>
Thu, 26 Sep 2024 06:59:42 +0000 (08:59 +0200)
committerGeorgi Gerganov <redacted>
Sun, 29 Sep 2024 18:15:37 +0000 (21:15 +0300)
commit544f409b4bd8fc98a3e87820f0ac934e00402de7
tree53c3939f01ddddb97bf407befeeff6563e66272c
parent6084bfb261b03f812de2255b05b6b5bb8d1c7171
vulkan : argsort barriers must be under uniform control flow (ggml/951)

a return before a barrier (that happens only in some threads in
a workgroup) leads to UB.
While the old code actually works on some devices,
it fails on some others (i.e. "smaller" GPUs).

BTW, I think it would be better to set specialization constants
when the graph is built, in that way the local workgroup
could be sized appropriately.
But it would take a lot of work.

Signed-off-by: Salvatore Mesoraca <redacted>
ggml/src/vulkan-shaders/argsort.comp