]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commit
fix: free ctx_copy in ggml_opt_free to plug per-training-session leak (#21592)
authorRealOrko <redacted>
Wed, 8 Apr 2026 15:40:15 +0000 (16:40 +0100)
committerGitHub <redacted>
Wed, 8 Apr 2026 15:40:15 +0000 (17:40 +0200)
commit2dcb7f74edde532831c5ee9a9b6c403f2b68854f
treea5cb0e108b963b7c3dd580b8a729ad444b60a1f8
parent660600081fb7b9b769ded5c805a2d39a419f0a0d
fix: free ctx_copy in ggml_opt_free to plug per-training-session leak (#21592)

* fix: free ctx_copy in ggml_opt_free to plug per-training-session leak

ggml_opt_alloc populates opt_ctx->ctx_copy via a free+init pair every
time the allocated graph shape changes. The last ctx_copy from the
final ggml_opt_alloc call survives until ggml_opt_free is invoked,
but ggml_opt_free was only freeing ctx_static and ctx_cpu, never
ctx_copy. Each opt_ctx lifetime therefore leaks the final per-batch
context — ~900 KB for a typical GNN training session in
sindarin-pkg-tensor, surfaced via AddressSanitizer.

ctx_copy is nullptr-initialized and ggml_free() handles NULL safely,
so the new release is guard-free.

* Update ggml/src/ggml-opt.cpp

Co-authored-by: Johannes Gäßler <redacted>
---------

Co-authored-by: realorko <redacted>
Co-authored-by: Johannes Gäßler <redacted>
ggml/src/ggml-opt.cpp