]> git.djapps.eu Git - pkg/ggml/sources/whisper.cpp/commit
vulkan : argsort barriers must be under uniform control flow (ggml/951)
authorSalvatore Mesoraca <redacted>
Thu, 26 Sep 2024 06:59:42 +0000 (08:59 +0200)
committerGeorgi Gerganov <redacted>
Thu, 3 Oct 2024 09:22:17 +0000 (12:22 +0300)
commit2a29afd4c6bcfa00321018081a9f13525c7a3f85
treeb16345f2a0d3a51ae969069e14e6dae24f021753
parent5963004ff9e2748cdfc1cad09adc5a5b3d4cd89e
vulkan : argsort barriers must be under uniform control flow (ggml/951)

a return before a barrier (that happens only in some threads in
a workgroup) leads to UB.
While the old code actually works on some devices,
it fails on some others (i.e. "smaller" GPUs).

BTW, I think it would be better to set specialization constants
when the graph is built, in that way the local workgroup
could be sized appropriately.
But it would take a lot of work.

Signed-off-by: Salvatore Mesoraca <redacted>
ggml/src/vulkan-shaders/argsort.comp