]> git.djapps.eu Git - pkg/ggml/sources/llama.cpp/commit
model-saver : fix expert shared/chunk FFN length key clobber (#26693)
authorCaleb DeLeeuw <redacted>
Mon, 10 Aug 2026 06:32:01 +0000 (23:32 -0700)
committerGitHub <redacted>
Mon, 10 Aug 2026 06:32:01 +0000 (09:32 +0300)
commit0377426cef5d211b397f72b1b37adbcd480fbb65
tree1386941415fc024940e0f82e6fd0586c84e21f90
parentaea252fb4a8b7f24bcfa9bba6da06100e3848d19
model-saver : fix expert shared/chunk FFN length key clobber (#26693)

The saver called add_kv with LLM_KV_EXPERT_SHARED_FEED_FORWARD_LENGTH twice, the
second time passing n_ff_chexp. gguf_set_val_u32 removes-then-appends, so the second
call clobbers the first: the saved shared_feed_forward_length ends up as n_ff_chexp
(0 for every arch except GroveMoE), and expert_chunk_feed_forward_length is never
written at all.

So a save->load roundtrip of any MoE model with a shared expert loses n_ff_shexp. On
reload the arch falls back to n_ff for the shexp tensor shape, that no longer matches
the saved tensor, and the model FAILS to load. Hits qwen2moe, qwen3-next, granite-moe,
hunyuan-moe, ernie4.5, bailingmoe2, nemotron-h, and the other shared-expert MoEs.

Fix: the second call writes LLM_KV_EXPERT_CHUNK_FEED_FORWARD_LENGTH.

test-llama-archs: set expert_shared_feed_forward_length to a value distinct from n_ff
in the MoE setup so the roundtrip exercises it. Without the fix the reload fails on a
shexp tensor-shape mismatch; with it, every arch roundtrips clean.
src/llama-model-saver.cpp
tests/test-llama-archs.cpp